fix: 나갔던 약속에 재참여가 되지 않는 문제 개선 #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 48 files 48 suites 6s ⏱️ Results for commit 30c968c. |
📝 Test Coverage Report
|
hyeon0208
approved these changes
Nov 4, 2024
eun-byeol
approved these changes
Nov 4, 2024
|
[제안] |
mzeong
requested changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #879
📝 작업 내용
기존에 약속-회원의 유니크 조건으로인해 퇴장했던 약속에 재참여가 불가하다는 이슈가 발생했습니다.
그렇다고 이 조건을 해제해버리면 동일 약속에 회원이 무한대로 재참여할 수 있게 되는 문제가 발생합니다.
따라서 유니크 조건에 삭제 여부를 같이 걸어서 퇴장했던 약속의 재참여를 가능하게 하되 퇴장하지 않은 참여자의 경우 재참여를 불가하도록 설정하였습니다.
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
테스트는 유저 행동 시나리오라고 생각하여 dynamicTest로 인수 테스트를 작성하였습니다.
불필요한 작업이라 생각되면 단위 테스트로 바꿀 예정이니 의견 남겨주세요.