[MVC 구현하기 - 3단계] 히이로(문제웅) 미션 제출합니다. #587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 무민, 히이로입니다!
전에 말씀드린대로 최대한 빠르게 진행해봤습니다.
혹시 빠뜨린 부분이 있다면 리뷰 부탁드릴게요 ㅎㅎ...
가장 궁금했던 점은 DispatcherServletInitializer는 왜 app 패키지 내에 존재해야 제대로 초기화가 진행되는가 입니다. 나름대로 디버깅을 찍어보면서 알아보려다가 시간 문제로 일단 리뷰 요청을 드리게 되었는데 무민에게도 한 번 질문드려보고 싶습니다. 😄
그리고 디스패처 서블릿이나 view에 대한 테스트 코드는 리팩토링 하면서 함께 작성해보도록 하겠습니다!
감사합니다~!! 🙇