Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Tests] - Re-enable disabled UI Tests #17281

Closed
9 tasks done
jostnes opened this issue Oct 6, 2022 · 5 comments · Fixed by #17312
Closed
9 tasks done

[UI Tests] - Re-enable disabled UI Tests #17281

jostnes opened this issue Oct 6, 2022 · 5 comments · Fixed by #17312
Assignees
Labels
[Type] Task UI Tests Anything related to automated UI Tests.

Comments

@jostnes
Copy link
Contributor

jostnes commented Oct 6, 2022

There are 9 UI Tests that are currently disabled on WPAndroid. This is to track work to re-enable the tests or to remove them depending on the investigation results:

List of test cases:

  • e2eMessageCanBeSent
  • e2eSendButtonEnabledWhenTextIsEntered
  • e2ePublishFullPostClassic
  • e2ePublishSimplePostClassic
  • e2eLoginWithMagicLink
  • e2eLoginWithPasswordlessAccount
  • e2eLoginWithEmailPassword
  • e2eNavigateThroughPosts
  • e2eLikePost
@jostnes jostnes added [Type] Task UI Tests Anything related to automated UI Tests. labels Oct 6, 2022
@jostnes
Copy link
Contributor Author

jostnes commented Oct 6, 2022

For the e2eMessageCanBeSent test, I'm leaning towards removing it from the test suite for a couple of reasons:

  1. This test has not been enabled in CI since its creation (see: PR)
  2. As discussed in the PR, it would be noisy if this test ran every build and I'm not sure if the current value of the test (how many times has this feature stopped working, how often is this screen updated) would justify the amount of noise from it. There's currently no clean-up on Zendesk side, there are suggestions but again I'm not sure if the effort to implement that would be worth it for this one test.

@pachlava WDYT? I'll create the PR to remove this test soon if there are no objections to this, if we decide in the future that this test case has become critical we can always get it back from git history

@pachlava
Copy link
Contributor

pachlava commented Oct 6, 2022

No objections for e2eMessageCanBeSent removal @jostnes 🙂

@jostnes
Copy link
Contributor Author

jostnes commented Oct 11, 2022

For e2eSendButtonEnabledWhenTextIsEntered the reason it's failing in the CI is because the Contact Support screen is taking a very long time to load or maybe doesn't load at all (I can confirm that it works locally).

I ran the test a few times by increasing the waiting time to wait for elements on the Contact Support screen and it was still stuck at loading on the Contact Support screen (added normal wait, increased wait time to 250ms, increased wait time to 400ms):
image

I'm not sure why the screen doesn't load when running on FTL (it loads fine when testing using a local emulator), I'll revisit this after going through the other test cases. If we find that there's no solution to this one, I'd propose removing this from the test suite too since it isn't adding much value if we can't run it on FTL.

@jostnes
Copy link
Contributor Author

jostnes commented Oct 11, 2022

For e2ePublishFullPostClassic and e2ePublishSimplePostClassic, I'll be removing these two. This is the issue related to these two test cases.

There is an internal discussion related to these two test cases: p9ugOq-20E-p2 and based on the discussion, looks like the tests are currently low-priority and have not been looked at for ~1 year. I've also looked at GitHub issues and PRs and have not seen any recent classic editor-related issues/PRs, confirming that this is a low-priority feature.

@jostnes
Copy link
Contributor Author

jostnes commented Oct 13, 2022

After revisiting e2eSendButtonEnabledWhenTextIsEntered looks like it does work in FTL, I may have used a wrong element identifier previously which was why it wasn't working previously but after updating to the correct one it works fine now. This is PR to re-enable the test, should be the last one before we mark this task as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task UI Tests Anything related to automated UI Tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants