Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetpack Compose] Resolve UnusedMaterialScaffoldPaddingParameter Lint Warnings #18481

Closed
ParaskP7 opened this issue May 22, 2023 · 1 comment
Closed

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented May 22, 2023

As part of #18364 this commit ebd5152 suppressed all unused material scaffold padding parameter Lint warnings.

  • Warning Message: Content padding parameter it is not used
  • Explanation: The content lambda in Scaffold has a padding parameter which will include any inner padding for the content due to app bars. If this parameter is ignored, then content may be obscured by the app bars resulting in visual issues or elements that can't be interacted with.

These Lint warnings were suppressed, that is, instead of them being resolved, since a resolution would require a proper investigation and testing. As such, it was decided to ignore those as out of scope, for the time being, and so as to not introduce any (potential) breaking changes to any scaffold related functionality overall.

This issue is exactly about that, that is, to try and resolve as many of the currently suppressed UnusedMaterialScaffoldPaddingParameter Lint warnings.

Cc @thomashorta @ovitrif

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 22, 2023

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@ParaskP7 ParaskP7 changed the title [Jetpack Compose] Resolve [Jetpack Compose] Resolve 'UnusedMaterialScaffoldPaddingParameter' Lint Warnings May 22, 2023
@ParaskP7 ParaskP7 changed the title [Jetpack Compose] Resolve 'UnusedMaterialScaffoldPaddingParameter' Lint Warnings [Jetpack Compose] Resolve UnusedMaterialScaffoldPaddingParameter Lint Warnings May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants