Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images with links that open new tabs do not have rel values when published from mobile #1458

Closed
mchowning opened this issue Oct 17, 2019 · 3 comments
Labels
[Type] Bug Something isn't working

Comments

@mchowning
Copy link
Contributor

mchowning commented Oct 17, 2019

Summary

In my testing, when publishing a post from mobile that will open in a new tab, the resulting link in the published post does not have any rel values:

<a href="alink.com" target="_blank">

whereas publishing a post from web does have "noopener" and "noreferrer" rel values, even if the user inputs no rel values when editing the image link (can only add custom rel values from the web currently):

<a href="alink.com" target="_blank" rel="noopener noreferrer">

Background

This issue began occurring because of a recent change that the web side made to stop displaying "noopener" and "noreferrer" rel attributes to the user (issue PR). In particular, the addition of "noopener" and "noreferrer" rel attributes was removed from image blocks. The reason behind this change according to the related issue was just to avoid displaying these two rel values to the user. This fix appears to work fine on web in my testing because a post published from web has those values in the html for the relevant link, but when a post is published from mobile I'm not seeing those rel values in the html of the published post.

Needs Verification

The behavior I am observing seems very odd because, in my testing, both mobile and web are saving the same attributes for the block (and even have the same output from the save function), but they're resulting in a different output in the published post. This makes me suspicious that there could be an issue with my testing (although I've reproduced this issue multiple times). If someone else has trouble reproducing this issue, then it seems very possible that there may just be something weird going on with my testing setup.

@hypest
Copy link
Contributor

hypest commented Oct 21, 2019

Maybe those attributes are added by the backend (WordPress) itself. Perhaps @donmhico or @jorgefilipecosta can verify.

@hypest
Copy link
Contributor

hypest commented Jun 11, 2020

Is this still occurring? If yes, can we add steps to reproduce? Thanks!

@mchowning
Copy link
Contributor Author

I cannot reproduce this issue on WPAndroid alpha-234, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants