feat: Improvements to IDKit JS v0 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
m1guelpf
commented
Dec 13, 2022
•
m1guelpf
commented
- loading state when you’re requesting SMS and verifying the code
- the screen when you click the “?” button in the header
- setting the captions/text via config
- auto-dismiss the modal on success
- passing the nullifier hash & proof details (signature for phone, merkle_root & proof for orb signal) to the client app
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paolodamico
approved these changes
Dec 15, 2022
m1guelpf
changed the title
m1guelpf
deleted the
miguelpiedrafita-wid-193-improvements-to-idkit-js-v0
branch
This was referenced Mar 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.