Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misc changes #43

Merged
merged 7 commits into from
Jan 19, 2023
Merged

feat: misc changes #43

merged 7 commits into from
Jan 19, 2023

Conversation

m1guelpf
Copy link
Member

No description provided.

@m1guelpf m1guelpf self-assigned this Jan 19, 2023
@m1guelpf m1guelpf linked an issue Jan 19, 2023 that may be closed by this pull request
@m1guelpf m1guelpf changed the title misc changes feat: misc changes Jan 19, 2023
@@ -0,0 +1,16 @@
import type { FC, HTMLAttributes } from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a readme to the Icons folder that explains where to get the icons from to ensure we consistently use icons from the same library.

@paolodamico
Copy link
Contributor

lfg 🔥

@paolodamico
Copy link
Contributor

also, nice branch name

@paolodamico paolodamico merged commit aec2763 into main Jan 19, 2023
@paolodamico paolodamico deleted the naming-branches-is-hard branch January 19, 2023 18:21
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants