feat: Migrate to app_id architecture, remove external phone support & more #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paolodamico
reviewed
Feb 21, 2023
m1guelpf
changed the title
paolodamico
reviewed
Feb 21, 2023
paolodamico
reviewed
Feb 21, 2023
paolodamico
reviewed
Feb 21, 2023
paolodamico
deleted the
feat/idk-how-to-call-it-but-like-full-refactor
branch
This was referenced Mar 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT E2E TESTED YET, BLOCKED BY NEW SIMULATOR
wld_worldIDVerificationspecapp_id,action, and optionallyaction_descriptionapp_idandactionare treated as strings, and theexternal_nullifieris encoded w/abi.encodePacked(hashedAppId, action).hashToField()app_idis a string andactionis a custom encoding, provided by callingsolidityEncode(typesArray, valuesArray)(needs a better name). Theexternal nullifieris encoded w/abi.encodePacked(hashedAppId, ...action).hashToField().