Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutations should not be cached #196

Closed
jasonbahl opened this issue Feb 21, 2023 · 2 comments · Fixed by #234
Closed

Mutations should not be cached #196

jasonbahl opened this issue Feb 21, 2023 · 2 comments · Fixed by #234
Assignees
@jasonbahl
Labels
type: bug Issue that causes incorrect or unexpected behavior

Comments

@jasonbahl
Copy link
Collaborator

Currently mutations are being cached in the object cache, and they should not be.

Steps to reproduce:

  • activate WPGraphQL Smart Cache
  • Under "GraphQL > Settnigs > Cache" enable "Use Object Cache"
  • As a public, not-logged-in user, execute a mutation via GraphQL POST request, (like createComment, as shown below)
  • Execute the same mutation a 2nd time, and see the response that "This response was not executed at run-time but has been returned from the GraphQL Object Cache"

CleanShot 2023-02-21 at 12 53 23
@jasonbahl jasonbahl added the type: bug Issue that causes incorrect or unexpected behavior label Feb 21, 2023
@jasonbahl jasonbahl self-assigned this Feb 21, 2023
@zngly-vlad zngly-vlad mentioned this issue Apr 24, 2023
Closed
@DanielSusanu
Copy link

Hey Jason,

Is there an update on this?

I am on version 1.1.1 and Im having the same issue.

Kind Regards,

@markkelnar
Copy link
Contributor

@DanielSusanu yes, working on it this sprint. Will update again soon.

@markkelnar markkelnar mentioned this issue Jul 21, 2023
Merged
@jasonbahl jasonbahl mentioned this issue Jul 21, 2023
Open
markkelnar added a commit to markkelnar/wp-graphql-smart-cache that referenced this issue Jul 25, 2023
@markkelnar
Merge branch 'bug/wp-graphql#196-mutations-shouldnt-be-cached' into b…
fa961dc 
…ug-mutation-should-not-cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonbahl jasonbahl

Labels
type: bug Issue that causes incorrect or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: do not cache mutations to object cache results markkelnar/wp-graphql-smart-cache
3 participants
@markkelnar @jasonbahl @DanielSusanu