Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 9 compatibility #19

Closed
galbus opened this issue Apr 28, 2022 · 3 comments · Fixed by #21
Closed

PHPUnit 9 compatibility #19

galbus opened this issue Apr 28, 2022 · 3 comments · Fixed by #21

Comments

@galbus
Copy link

galbus commented Apr 28, 2022

When I attempt to composer require this package in my PHPUnit 9 project it fails with the following dependency/version error:

    - Root composer.json requires wp-graphql/wp-graphql-testcase ^2.1.3 -> satisfiable by wp-graphql/wp-graphql-testcase[v2.1.3].
    - wp-graphql/wp-graphql-testcase v2.1.3 requires phpunit/phpunit ^7.5 || ^8.5.0 -> found phpunit/phpunit[7.5.0, ..., 7.5.20, 8.5.0, ..., 8.5.26] but it conflicts with your root composer.json require (^9.5).

See Supported PHPUnit versions for PHPUnit's release timeline.

@justlevine
Copy link
Contributor

Issue is that TraversableContains becomes an abstract in 9.x so we'd need a shim for TraversableContainsIdentical to maintain compat with 8.5 and below.
I'd offer, but phpunit is not my wheelhouse.

@kidunot89
Copy link
Member

@galbus @justlevine This issue should be fixed with the release of v2.2.0

@justlevine
Copy link
Contributor

@kidunot89 you sure ?

image
Its also causing WPGraphQL's core GH actions to fail (since wp-graphql-testcase was set to ~2.1, it gets updated to 2.3 by the docker entrypoint )

cc: @jasonbahl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants