Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate WordPress Actions / Filters ☕️ #4

Closed
19 of 20 tasks
jasonbahl opened this issue Nov 27, 2023 · 1 comment · Fixed by #10
Closed
19 of 20 tasks

Migrate WordPress Actions / Filters ☕️ #4

jasonbahl opened this issue Nov 27, 2023 · 1 comment · Fixed by #10
Assignees
Labels
status: actionable Ready for work to begin

Comments

@jasonbahl
Copy link
Collaborator

jasonbahl commented Nov 27, 2023

User Story

As a WordPress developer, I would like to be able to actions/filter various parts of the GraphiQL IDE to provide customized functionality.

Acceptance Criteria

  • new action/filter names are prefixed with wpgraphqlide_

Existing Hooks

JavaScript Filters

JavaScript Action

PHP Filters

PHP Actions

Hooks / Filters should be added to the new version with different names to prevent possible conflicts with folks running a plugin that extended the old GraphiQL IDE (i.e. graphiql_app -> graphiql_ide_app)

  • Document how to use these hooks/filters (at minimum in the merged PR that implements it, so we can add the docs to the website or wherever else when appropriate)

Updated Filters

PHP

  • wpgraphqlide_capability_required
  • wpgraphqlide_enqueue_script
  • wpgraphqlide_external_fragments
  • wpgraphqlide_context (new hook! no existing mapping)

JavaScript

  • wpgraphqlide_rendered
  • wpgraphqlide_cleanup (new hook! no existing mapping)
@jasonbahl jasonbahl added this to the Merge Candidate milestone Nov 27, 2023
@josephfusco josephfusco changed the title WordPress Hooks / Fitlers WordPress Hooks / Filters Dec 18, 2023
@josephfusco josephfusco added the status: actionable Ready for work to begin label Jan 22, 2024
@josephfusco josephfusco self-assigned this Feb 6, 2024
@jasonbahl jasonbahl changed the title WordPress Hooks / Filters WordPress Actions / Filters Feb 15, 2024
@jasonbahl jasonbahl changed the title WordPress Actions / Filters Migrate WordPress Actions / Filters ☕️ Feb 15, 2024
@josephfusco josephfusco linked a pull request Feb 19, 2024 that will close this issue
@josephfusco josephfusco pinned this issue Feb 22, 2024
@josephfusco josephfusco reopened this Feb 26, 2024
@josephfusco
Copy link
Member

Due to architectural limitations of the current GraphiQL IDE, we will not be performing a 1:1 migration as original planned. Instead, we will capture the spirit of these pluggable areas in a new tracking ticket. #109

Closing this and we continue discussion in #109

@josephfusco josephfusco closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
@josephfusco josephfusco unpinned this issue Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: actionable Ready for work to begin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants