Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger.onChange has no test #6777

Closed
spacey-sooty opened this issue Jun 27, 2024 · 3 comments · Fixed by #6849
Closed

Trigger.onChange has no test #6777

spacey-sooty opened this issue Jun 27, 2024 · 3 comments · Fixed by #6849

Comments

@spacey-sooty
Copy link
Contributor

No description provided.

@KangarooKoala
Copy link
Contributor

What behavior do we want to test? For example, what is desired behavior of onTrue() if the Trigger condition starts true? (See #5608)

@spacey-sooty
Copy link
Contributor Author

I think the behaviour of Trigger.onChange is easier to test see robotpys test robotpy/robotpy-commands-v2@3eac469#diff-6d61aa359d85f8cd064c7b5a5ad419dacaec0575fe61e1ee86498c64037d5e4cR45

@KangarooKoala
Copy link
Contributor

Oops, somehow I missed that this was specifically the onChange() method, not all of the trigger binding methods.

@WispySparks WispySparks mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Trigger.onChange() test WispySparks/allwpilib
2 participants
@KangarooKoala @spacey-sooty