Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

"output shaft" is poorly defined #436

Closed
calcmogul opened this issue Jun 27, 2022 · 1 comment · Fixed by #524
Closed

"output shaft" is poorly defined #436

calcmogul opened this issue Jun 27, 2022 · 1 comment · Fixed by #524
Labels
documentation Improvements or additions to documentation

Comments

@calcmogul
Copy link
Member

sysid-application/src/main/native/cpp/view/Logger.cpp
110:      "The logger assumes that the code will be sending recorded output shaft "

sysid-application/src/main/native/cpp/view/Generator.cpp
564:      "This is the gearing between the encoder and the output shaft. For "

sysid-application/src/main/native/cpp/view/Analyzer.cpp
768:        "The gearing between the encoder and the output shaft (# of "
769:        "encoder turns / # of output shaft turns).");

Is each of them referring to the motor shaft or the wheel shaft? The third one implies wheel shaft, but the first two imply motor shaft.

@calcmogul calcmogul added the documentation Improvements or additions to documentation label Jun 27, 2022
@Piphi5
Copy link
Collaborator

Piphi5 commented Jun 27, 2022

I believe each of them refers to the motor shaft. The surrounding code seems to be in the context of motor shaft / converting the readings into rotations. The conversion to wheel shaft is handled elsewhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants