-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack corruption #761
Comments
Another one based on #770
Just in case, reducing it to:
Trigger the bug but does not make it visible to user for some reasons. |
Thanks, I think we have a fix for this, at least in my engine where I have a fix applied for another bug, this one is giving expected results too. |
Could you issue a pull request of that fix before merging? Since that stuff is in the critical path, and can have possible huge impacts in speed. I also have a crude patch that fix that issue by doing a STORE_FRAME/LOAD_FRAME around the Another solution would be to revert, the function call change. So before you push, please allow to evaluate your solution. |
Could you provide both patch for review. Numbers are too pretty good to be
true.
|
#801 Seems to be another variation of the issue. |
When will this MR be available? |
I have no estimate. Waiting for @munificent to send some thoughts my way. (It IS 2020 though, it's reasonable to expect some delay due to priorities) |
All cases listed above are working as expected with #807 merged! |
Here is a reduced test to the long standing stack corruption issue:
Instead of returning caramba, second call to it returns 42. I have not been able to weaponize it to make the test crash, but at least it can be tested somehow.
The text was updated successfully, but these errors were encountered: