Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Browser Chooser 2 #167

Closed
McDemigod opened this issue Jan 25, 2021 · 6 comments
Closed

Does not work with Browser Chooser 2 #167

McDemigod opened this issue Jan 25, 2021 · 6 comments
Labels
Bug This is either an issue that describes a bug or a PR that resolves a bug Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.

Comments

@McDemigod
Copy link

Background Information:

  • Build: d8fb31b
  • WSL: tested in Pengwin & Ubuntu 20.04
  • Version:

Describe the bug
Nothing appears when Windows has Browser Chooser 2 set as default browser

To Reproduce
Set default in Windows settings.

Expected behavior
Should open Browser Chooser window with options to select other browsers installed in Windows.

@patrick330602
Copy link
Member

Hi,

Thanks for the report. I will check it this weekend.

@patrick330602 patrick330602 added the Bug This is either an issue that describes a bug or a PR that resolves a bug label Jan 28, 2021
@patrick330602
Copy link
Member

patrick330602 commented Feb 18, 2021

Hi,

After some testing, this related to the upstream issue here:
https://bitbucket.org/gmyx/browserchooser2/issues/47/cant-open-a-link-on-slack

EDIT: After some more testing, it is still not working it seems. I will try to update the logic of opening the protocol

@patrick330602 patrick330602 added Question: To be included This question is answered, but not yet included in the FAQ page in the WSL Utilities Wiki Upstream This is a bug that related to WSL, distribution or the packages wslu depends on. Target: 3.x This is targeted to the 3.x version. Status: On Hold This is being worked on but currently stopped the work due to issues. Target: 4.x This is targeted to the 4.x release. and removed Question: To be included This question is answered, but not yet included in the FAQ page in the WSL Utilities Wiki Upstream This is a bug that related to WSL, distribution or the packages wslu depends on. Target: 3.x This is targeted to the 3.x version. labels Feb 18, 2021
@patrick330602
Copy link
Member

patrick330602 commented Feb 18, 2021

Due to some upstream issue, I am pausing the fix for this: microsoft/WSL#6565

And moving the target to 4.x.

@patrick330602 patrick330602 added Wont Fix This bug will not be fixed. and removed Status: On Hold This is being worked on but currently stopped the work due to issues. Target: 4.x This is targeted to the 4.x release. labels Jul 1, 2021
@patrick330602
Copy link
Member

After several more tests and inactivity on the Microsoft side, with limited resources, I won't fix this bug.

@patrick330602 patrick330602 added Target: 4.x This is targeted to the 4.x release. and removed Wont Fix This bug will not be fixed. labels Jul 16, 2021
@patrick330602
Copy link
Member

Thinking about solving this issue by providing alternative engine.

@patrick330602 patrick330602 reopened this Jul 16, 2021
@patrick330602 patrick330602 added the Status: In Progress This is being worked on and not ready. label Oct 4, 2021
@patrick330602 patrick330602 added Status: Pending Release This is fixed but not yet released. and removed Status: In Progress This is being worked on and not ready. labels Apr 19, 2022
@patrick330602 patrick330602 moved this to In progress in wslu Roadmap Jun 24, 2022
@patrick330602 patrick330602 moved this from In progress to Done in wslu Roadmap Aug 18, 2022
@patrick330602 patrick330602 added Status: Patched This is fixed and is part of a released version. and removed Status: Pending Release This is fixed but not yet released. labels Aug 27, 2022
@isadoraq
Copy link

isadoraq commented Feb 3, 2023

Hey, there!
I seem to have the same issue.
Are the following steps supposed to be enough to not have this issue with BrowserChooser2?

export BROWSER=wslview
export WSLVIEW_DEFAULT_ENGINE=cmd_explorer
xdg-open http://www.google.com

It's weird because it works if the default browser is something else, like Brave or Firefox.
So I'm not sure the issue is indeed with wslview...
But browser chooser definitely works when trying on Windows:

cmd.exe /c start www.google.com
powershell.exe Start http://www.google.com
explorer.exe http://www.google.com

For some reason start won't work for browserchooser+wsl, but these do:

cmd.exe /c explorer http://www.google.com
powershell.exe explorer http://www.google.com
explorer.exe http://www.google.com

But then if you were to try skipping wslview and using export BROWSER=explorer.exe you start having issues with special characters (e.g. ?).
It's a real pickle. Can you shine a light if I'm ignoring some possible fix/solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either an issue that describes a bug or a PR that resolves a bug Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.
Projects
Status: Done
Development

No branches or pull requests

3 participants