-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FileSize validator #365
Add FileSize validator #365
Conversation
…eed help to sort it out.
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 99.67% 99.68% +0.01%
==========================================
Files 18 18
Lines 911 941 +30
Branches 74 76 +2
==========================================
+ Hits 908 938 +30
Misses 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good all things
Is anything else needed to enable this branch to be merged? |
This work builds upon @mvi-x's code in #309 to add a
FIleSize
validator.Refs #307