Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts for 'Accept/Revert url/test' buttons #317

Closed
lewandowskidawid opened this issue Aug 9, 2018 · 3 comments
Closed

Keyboard shortcuts for 'Accept/Revert url/test' buttons #317

lewandowskidawid opened this issue Aug 9, 2018 · 3 comments
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help.

Comments

@lewandowskidawid
Copy link

Version used

  • AET 2.1.6

Context of the issue/feature

There are buttons for accepting/reverting collected patterns in AET reporting App (check attached screens), but it is inconvenient to use them while navigating with keybaord shortcuts bettween different reports, because the user has to click them using mouse cursor.

The aim of this task is to provide dedicated keyboard shortcuts for accept/revert buttons.

Solution proposition:
Introduce following keyboard shortcuts:
A - for accepting suite/test/url
R - for reverting suite/test/url
ctrl - modifier that will define that the specific opened test case should be accepted/reverted (ctrl + A - accepts opened test case ; ctrl + R - reverts opened test case )

@malaskowski malaskowski added enhancement help wanted Hey, contributor! We need your help. good first issue This is great opportunity to start your adventure with AET. labels Aug 9, 2018
@sp2mbn
Copy link

sp2mbn commented Sep 17, 2018

Ctrl+A and Ctrl+R are not proper shortcuts, because are natively used in browsers. IMHO Shift key will be better as a modifier.

@kaczymuczy
Copy link

If someone tries to enter "R" into the filter input then the shortcut will execute or not?

@sp2mbn
Copy link

sp2mbn commented Sep 17, 2018

I think it shouldn't, but existing shortcuts (e.q. "q" or "e") are executed. If it's not wanted behavior that all existing shortcuts should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help.
Projects
None yet
Development

No branches or pull requests

4 participants