Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New scroll page modifier #386

Closed
ernestosiak opened this issue Oct 11, 2018 · 1 comment
Closed

New scroll page modifier #386

ernestosiak opened this issue Oct 11, 2018 · 1 comment
Assignees
@ernestosiak
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help.

Comments

@ernestosiak
Copy link
Contributor

ernestosiak commented Oct 11, 2018 •
edited
Loading

Version used

  • AET 3.0.1

Context of the issue/feature

As a AET user I want to be able to scroll page to top / bottom / specific place. Now only available option is to use Execute JavaScript Modifier and custom script.

Only three attributes should be available:

  • position with value "top" or "bottom"
  • css
  • xpath

If none is provided, default would be position="bottom"

Possible usage examples:
<scroll position="top"/>
<scroll position="bottom"/>
<scroll css="#element_id"/>
<scroll xpath="//*[@id='element_id']"/>
@ernestosiak ernestosiak self-assigned this Oct 11, 2018
@malaskowski malaskowski added help wanted Hey, contributor! We need your help. good first issue This is great opportunity to start your adventure with AET. Hacktoberfest labels Oct 11, 2018
@ernestosiak ernestosiak mentioned this issue Oct 15, 2018
Merged
6 tasks
@tkaik
Copy link
Contributor

tkaik commented Oct 24, 2018

Done in #394

@tkaik tkaik closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ernestosiak ernestosiak

Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkaik @malaskowski @ernestosiak