-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio devices error logs #10
Comments
Can you open an issue on Aperture about that? We need to conditionally switch to the new API. |
This is a real pickle. We actually write to stderr because Apple logs unrelated things to stdout, and now they also do so on stdout... aperture-node/Sources/ApertureCLI/main.swift Lines 71 to 72 in e09011c
Maybe we could use something other than stdout/stderr. Our own stream maybe: https://stackoverflow.com/questions/24659200/are-the-extra-stdio-streams-in-node-js-child-process-spawn-blocking ? |
But if we do that we'll have to rebuild Aperture and have the swift runtime libraries issue, which I guess we'll run into eventually. I'm thinking for a temporary solution, we could try using regex to extract the devices from the other logs? I can try a small PR to see if that'll work. So all changes will be node related and we won't have to rebuild |
I prefer fixing it properly here and just do the workaround in Kap for now where we fall back to your macOS-audio-devices package. |
From wulkano/Kap#825 (comment)
Sometimes getting the audio devices from the swift script prints a lot of other stuff in stderr, and so the parsing fails, in which case we return the whole stderr.
Example return:
Not sure if that's an issue with Aperture itself, or with this package
It also looks like the method we use to get the devices is deprecated, even though I don't think that has anything to do with the logs: https://developer.apple.com/documentation/avfoundation/avcapturedevice/1390520-devices
The text was updated successfully, but these errors were encountered: