Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(graphqlmetrics): reduce allocated memory #1356

Merged
merged 9 commits into from
Nov 11, 2024
Merged

perf(graphqlmetrics): reduce allocated memory #1356

merged 9 commits into from
Nov 11, 2024

Conversation

Noroth
Copy link
Contributor

@Noroth Noroth commented Nov 9, 2024 •
edited
Loading

Motivation and Context

The memory consumption increased due to recent changes. This PR attempts to include some optimizations in that regard.

Additional enhancements

  • Prepare batch function now uses best effort approach to save as much data as possible in case of unexpected errors.
  • Errors will be logged instead of returned

Checklist

@Noroth Noroth changed the title improve(graphqlmetrics) reduce allocated memory improve(graphqlmetrics): reduce allocated memory Nov 9, 2024
@Noroth Noroth changed the title improve(graphqlmetrics): reduce allocated memory perf(graphqlmetrics): reduce allocated memory Nov 9, 2024
@Noroth Noroth marked this pull request as ready for review November 9, 2024 20:56
StarpTech
StarpTech requested changes Nov 9, 2024
View reviewed changes
graphqlmetrics/core/metrics_service.go Outdated Show resolved Hide resolved
graphqlmetrics/core/metrics_service.go Outdated Show resolved Hide resolved
graphqlmetrics/core/metrics_service.go Show resolved Hide resolved
StarpTech
StarpTech approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noroth Noroth merged commit ff4874b into main Nov 11, 2024
7 checks passed
@Noroth Noroth deleted the ludwig/reduce-memory-load branch November 11, 2024 13:53
git-hulk pushed a commit to git-hulk/cosmo that referenced this pull request Nov 12, 2024
@Noroth @git-hulk
perf(graphqlmetrics): reduce allocated memory (wundergraph#1356)
1d2a4af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

Assignees
No one assigned
Labels
graphqlmetrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noroth @StarpTech