New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt-airframe: Remove redundant import statements #1176

Closed

xerial opened this issue Jul 2, 2020 · 1 comment

Milestone

Member

xerial commented Jul 2, 2020 •

edited

Loading

This code seems insufficient for removing redundant import statements from the generated client code:

airframe/airframe-http/.jvm/src/main/scala/wvlet/airframe/http/codegen/HttpClientIR.scala

Line 63 in a2f6b70

loop(classDef).filter(requireImports).distinct.sortBy(_.name)

In addition, we need to remove:

scala.Option
scala.collection.immutable.{List, Map}
scala.util.Either

xerial added this to the Airframe 20 milestone

xerial mentioned this issue

Milestone: Airframe 21 #1375

Closed

90 tasks

xerial modified the milestones: Airframe 20, Airframe 21

Member Author

xerial commented Jan 16, 2021

Now sbt-airframe uses full class name for each occurrences instead of using import statements.

xerial closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment