-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airframe-log: possible merge into Scribe? #172
Comments
@darkfrog26 Hi. Nice to e-meet you! I'm aware of your project, scribe, especially because I also want to support Scala, Scala.js, and Scala.native (and upcoming new Scala bindings). Could you explain more about how do you want to merge? A current concern is:
|
Sorry for the very late response. I could have sworn I responded to this. Scribe has no references to As for reasons of a merge, I think there's so much duplication of effort in the logging space that I'd really like to see turn into a collaboration to push the ball forward instead of everyone creating their own copy of the same thing. You have some color support that I think could benefit Scribe, although in 2.5 we recently added some basic ANSI support. |
@darkfrog26 Thank you for the explanation. Although creating a sort of logging standard (like Scribe) sound good, the real world is not so simple. I don't mean any offense, but I do have very pragmatic opinions on using the shared libraries. For example,
|
A.) I agree that's a big frustration point for me as well. However, I'm typically very responsive. |
OK. Let's ignore A) part for a while because you and I will be active Scala developers, at least, for several years. For B) and C), airframe-log also include:
These features are mentioned in this doc: |
@darkfrog26 Some facts:
What I need right now:
|
|
FYI, TwitterServer is providing a UI for log level configuration through JMX https://twitter.github.io/twitter-server/Admin.html#admin-logging |
Very cool. The same could be done with Scribe since it's runtime configurable, but providing a hook via JMX would be very useful for integration with such services. |
@darkfrog26 Let me close this ticket because airframe is designed to be self-dependent as much as possible, and creating an external dependency is not an ideal for us. |
I really like a lot of the features related to coloring in your logging library. Would you be interested in a possible merging of your project with Scribe (https://github.com/outr/scribe)?
The text was updated successfully, but these errors were encountered: