return in finally swallows exceptions.

[iritkatriel]

In

Phoenix/wx/lib/agw/flatmenu.py

Line 5364 in 82b1c7a

return super().Destroy(*args, **kwargs)

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[komoto48g]

@swt2c, I commented #2373 and proposed finally return.
But it seems fine even if it doesn't return a bool value, as it can close without issues. If I understand correctly, this is because wx.lib.agw.flatmenu.FlatMenu is a subclass of wx.PopupWindow, not wx.TopLevelWindow.
So to keep the code healthy, I'd make a PR like this:

     def Destroy(self, *args, **kwargs):
        self.Clear()
        return super().Destroy(*args, **kwargs)