Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LspWsConnection does not implement on, off. #20

Open
krassowski opened this issue Jul 19, 2019 · 2 comments
Open

LspWsConnection does not implement on, off. #20

krassowski opened this issue Jul 19, 2019 · 2 comments

Comments

@krassowski
Copy link

First off, thanks for devolving this adapter, it's very useful!

I am getting following error when trying to set-up the example from README:

Type "LspWsConnection" is not assignable to parameter of type "ILspConnction"
Type "LspWsConnection" is missing following properties from type "ILspConnction": on, off

I can @ts-ignore it, but after looking through the sources it seems that the on & off implementation is indeed missing - or am I missing something?

@krassowski
Copy link
Author

Okey, it has to be something on my part/versions incompatibility. I've just realized that it is probably hidden within the EventEmitter.

@krassowski
Copy link
Author

Solved by:

npm install events
npm install @types/events

Should events and types for events be included in the package.json's dependencies / devDependencies?

@krassowski krassowski reopened this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant