feat: Adds support for multichoiceset quiz questions. #228
Conversation
added an additional case statement to handle multichoiceset qtype. Will need to add a better default handler for future qtypes.
|
@ryansmith94 I added an updated qtype handling. I will work on the default handling of future question types later. This is just a quick addition for a qtype I am using and is missing. It should be handled as the multichoice. Since if it is correct or not is handled by Moodle and will display properly if different. |
There was a problem hiding this comment.
I think we should probably create a test for this in tests/mod_quiz/attempt_submitted in case someone changes the way this works in future and forgets to add tests. For now it can just be a duplicate of the tests/mod_quiz/attempt_submitted/multichoice folder but replace uses of "multichoice" with "multichoiceset".
|
Okay I'll update. Do you want me to include the additional changes I have done to the multichoice statement? Since I am adding the correct response and potential answers to it or put that in other branch? |
|
nm I will use seperate branch |
test for multichoice set.
|
Okay can this be closed in favour of #233? |
|
@ryansmith94 This branch is just merging the question type, not the answers or the other items, you said you may not want. So this is so the question type all or nothing can be used in the handler. While the other branch is adding the other items that may or maynot be merged. |
|
Got it, thanks for clarifying 👍 |
|
Thanks for adding the tests @caperneoignis, just waiting to make sure the build passes before I merge this because I had to merge master into this PR 👍 |
ryasmi
changed the title
|
🎉 This PR is included in version 3.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
added an additional case statement to handle multichoiceset qtype. Will need to add a better default handler for future qtypes.
Description
Related Issues
PR Type