Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update open_dataset and dataset_keep_vars() to limit dataset to only 1 variable #105

Closed
tomvothecoder opened this issue Sep 21, 2021 · 0 comments · Fixed by #106
Closed
Assignees
Labels
type: enhancement New enhancement request

Comments

@tomvothecoder
Copy link
Collaborator

Is your feature request related to a problem? If yes, Please describe

The typical workflow is to work on a single variable at a time. XCDAT operations are performed on 1 variable in the Dataset, so it makes sense to limit the Dataset to 1 variable (and bounds)

This inherently makes the Dataset a CDAT TransientVariable, which is a variable with bounds.

Describe your proposed solution

  1. Update xcdat.dataset.open_dataset() arg keep_vars to var (type str)
  2. Update xcdat.dataset.dataset_keep_vars() arg keep_vars to var (type str)
  3. Remove code that transforms the input to a list of str.

Describe alternatives solutions you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant