Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PlayGames.GetSnapshotClient() API in Xamarin.GooglePlayServices.Games.V2 #972

Open
pekspro opened this issue Sep 11, 2023 · 6 comments
Labels
missing-api Java types/members not available in binding

Comments

@pekspro
Copy link

pekspro commented Sep 11, 2023

I'm working with a game, and I have been able to use leaderboards. But I also would like to add support for saved games:

https://developers.google.com/games/services/android/savedgames

But as I understand it there is no binding for com.google.android.gms.games.snapshot. Can this be added? Please, please, please :-)

@moljac
Copy link
Member

moljac commented Sep 19, 2023

@pekspro

Thanks for the feedback.

Seems like this artifact is not in the official repo:

https://maven.google.com/web/index.html

I found it here:

https://mvnrepository.com/artifact/com.google.android.gms/play-services-games/23.1.0

I cannot guarantee that bindings will be done in some reasonable time.

@stuartmilleruk
Copy link

I think the binding is in the official repo as a part of Play Services Games v2, in:

https://maven.google.com/web/index.html#com.google.android.gms:play-services-games-v2:19.0.0

At least, looking in the javadoc files there's documentation for it. Are the bindings automatically generated from this or do they need to be manually written? ( currently assessing the feasibility of adding some of this myself .. but still trying to figure out how things are put together in the Xamarin/.NET bindings )

@moljac
Copy link
Member

moljac commented Dec 27, 2023

@stuartmilleruk

Thanks for the feedback

How about:

https://www.nuget.org/packages/Xamarin.GooglePlayServices.Games.V2

??

@stuartmilleruk
Copy link

@moljac thanks... sorry, this thread was mentioned in my bug #975 ( PlayersClient classes are missing in the xamarin gpg plugin which makes it impossible to track player changes ) and I noticed the binding that @pekspro needed was in the v2 API as you say.

@pekspro does the V2 API have all the bits you're looking for?

@pekspro
Copy link
Author

pekspro commented Dec 29, 2023

@stuartmilleruk, I have tried the latest version of Xamarin.GooglePlayServices.Games.V2, and there is no PlayGames.GetSnapshotClient() that I think is needed :-(

As a side note, this nuget package works in .NET 7 projects, in .NET 8 compiling seems to fail :-(

@moljac
Copy link
Member

moljac commented Jul 27, 2024

@stuartmilleruk @pekspro

I did preliminary quick-n-dirty analysis and the problem is in few classes in GPS.Basementwhich were not surfaced, so it is not that trivial.

I will open PR in which I will try to fix this issues (not one class is missing).

@pekspro

As a side note, this nuget package works in .NET 7 projects, in .NET 8 compiling seems to fail :-(

Please open new issue for that.

PlayGames.GetSnapshotClient() that I think is needed

It was not surfaced because return type was not surfaced.

@jpobst jpobst changed the title Binding for com.google.android.gms.games.snapshot Missing PlayGames.GetSnapshotClient() API in Xamarin.GooglePlayServices.Games.V2 Sep 23, 2024
@jpobst jpobst transferred this issue from xamarin/GooglePlayServicesComponents Sep 23, 2024
@jpobst jpobst added the missing-api Java types/members not available in binding label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing-api Java types/members not available in binding
Projects
None yet
Development

No branches or pull requests

4 participants