Use media element play method when is looping is true and media is played to end (ios) #2006

FedericoNembrini · 2024-03-06T21:54:39Z

Description of Bug

Speed is lost when IsLooping=True because avPlayerViewController.Player?.Play(); is used to restart the player.

By using Play() the speed is respected.

XamarinCommunityToolkit/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/iOS/MediaElementRenderer.ios.cs

Lines 290 to 315 in 5a6062f

    
           protected virtual void Play() 
        
           { 
        
           	var audioSession = AVAudioSession.SharedInstance(); 
        
           	var err = audioSession.SetCategory(AVAudioSession.CategoryPlayback); 
        
           	if (err != null) 
        
           		Log.Warning("MediaElement", "Failed to set AVAudioSession Category {0}", err.Code); 
        
           	audioSession.SetMode(AVAudioSession.ModeMoviePlayback, out err); 
        
           	if (err != null) 
        
           		Log.Warning("MediaElement", "Failed to set AVAudioSession Mode {0}", err.Code); 
        
           	err = audioSession.SetActive(true); 
        
           	if (err != null) 
        
           		Log.Warning("MediaElement", "Failed to set AVAudioSession Active {0}", err.Code); 
        
           	if (avPlayerViewController.Player != null) 
        
           	{ 
        
           		avPlayerViewController.Player.Play(); 
        
           		Controller.CurrentState = MediaElementState.Playing; 
        
           		UpdateSpeed(); 
        
           	} 
        
           	if (Element.KeepScreenOn) 
        
           		SetKeepScreenOn(true); 
        
           }

Issues Fixed

Fixes [Bug] MediaElement bugs when 'IsLoop' is set to true #2002 (partially)

Behavioral Changes

PR Checklist

Has a linked Issue, and the Issue has been approved
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard
Updated documentation

…ayed to end

jfversluis · 2024-04-26T07:19:56Z

Now that we're so close to the sunsetting of Xamarin (and therefore also Xamarin Community Toolkit) unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR, we really appreciate it.

Please have a look at the evolution of the Xamarin Community Toolkit, The .NET MAUI Community Toolkit. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin user!

Use media element play method when is looping is true and media is pl…

1558687

…ayed to end

jfversluis closed this Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use media element play method when is looping is true and media is played to end (ios) #2006

Use media element play method when is looping is true and media is played to end (ios) #2006

FedericoNembrini commented Mar 6, 2024

jfversluis commented Apr 26, 2024

	protected virtual void Play()
	{
	var audioSession = AVAudioSession.SharedInstance();
	var err = audioSession.SetCategory(AVAudioSession.CategoryPlayback);

	if (err != null)
	Log.Warning("MediaElement", "Failed to set AVAudioSession Category {0}", err.Code);

	audioSession.SetMode(AVAudioSession.ModeMoviePlayback, out err);
	if (err != null)
	Log.Warning("MediaElement", "Failed to set AVAudioSession Mode {0}", err.Code);

	err = audioSession.SetActive(true);
	if (err != null)
	Log.Warning("MediaElement", "Failed to set AVAudioSession Active {0}", err.Code);

	if (avPlayerViewController.Player != null)
	{
	avPlayerViewController.Player.Play();
	Controller.CurrentState = MediaElementState.Playing;
	UpdateSpeed();
	}

	if (Element.KeepScreenOn)
	SetKeepScreenOn(true);
	}

Use media element play method when is looping is true and media is played to end (ios) #2006

Use media element play method when is looping is true and media is played to end (ios) #2006

Conversation

FedericoNembrini commented Mar 6, 2024

Description of Bug

Issues Fixed

Behavioral Changes

PR Checklist

jfversluis commented Apr 26, 2024