Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] LinkAll 'LinkedAwayGenericTypeAsOptionalMemberInProtocol' fails #11280

Open
spouliot opened this issue Apr 22, 2021 · 1 comment
Open
Labels
dotnet An issue or pull request related to .NET (6) test-only-issue The issue only affects tests
Milestone

Comments

@spouliot
Copy link
Contributor

Steps to Reproduce

  1. Run Link all for dotnet

Expected Behavior

No failure

Actual Behavior

LinkedAwayGenericTypeAsOptionalMemberInProtocol fails.

Xamarin.iOS.dll still has the type. There's quite a few things that are not removed - just not sure which one is responsible yet...

Environment

main

Example Project (If Possible)

link all.csproj

@spouliot spouliot added test-only-issue The issue only affects tests dotnet An issue or pull request related to .NET (6) dotnet-pri1 .NET 6: important for stable release labels Apr 22, 2021
@spouliot spouliot added this to the .NET 6 milestone Apr 22, 2021
@spouliot
Copy link
Contributor Author

With ILLink (dotnet) the types mentioned (as Type) inside an attribute are marked. This makes it impossible to pass this test.

[ProtocolMember (IsRequired = false, IsProperty = false, IsStatic = false, Name = "ConfigureView", Selector = "configureViewForParameters:", ParameterType = new Type [] { typeof (global::Foundation.NSSet<global::Foundation.NSString>) }, ParameterByRef = new bool [] { false })]

That's a "less than legacy" situation. However in other cases this different behaviour from the linker is positive, see #11985

@spouliot spouliot added dotnet-pri3 .NET 6: wishlist for stable release and removed dotnet-pri1 .NET 6: important for stable release labels Aug 12, 2021
@rolfbjarne rolfbjarne modified the milestones: .NET 6, .NET 7 Mar 29, 2022
@rolfbjarne rolfbjarne removed the dotnet-pri3 .NET 6: wishlist for stable release label Mar 29, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 7, .NET 8 Aug 26, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Sep 12, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet An issue or pull request related to .NET (6) test-only-issue The issue only affects tests
Projects
None yet
Development

No branches or pull requests

2 participants