Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths/filenames with special characters (Chinese, etc) can't be dragged and dropped onto Xenia #2210

Open
Margen67 opened this issue Jun 29, 2023 · 6 comments · May be fixed by #2212
Open

Paths/filenames with special characters (Chinese, etc) can't be dragged and dropped onto Xenia #2210

Margen67 opened this issue Jun 29, 2023 · 6 comments · May be fixed by #2212
Assignees
@gibbed
Labels
bug vfs

Comments

@Margen67
Copy link
Member

If you try to drag and drop a game that has certain characters in the path then Xenia tries to open itself: xenia.log
If Xenia is in a path that contains special characters the game's filename becomes corrupted: xenia.log

It must be opened by dragging and dropping. The issue doesn't occur with File > Open.
@gibbed gibbed self-assigned this Jun 29, 2023
@gibbed
Copy link
Member

gibbed commented Jun 29, 2023 •
edited
Loading

If you try to drag and drop a game that has certain characters in the path then Xenia tries to open itself: xenia.log

What kind of file is being drag&dropped here?

@Margen67
Copy link
Member Author

If you try to drag and drop a game that has certain characters in the path then Xenia tries to open itself: xenia.log

What kind of file is being drag&dropped here?

STFS, but it does the same thing with iso and xex.

@gibbed
Copy link
Member

gibbed commented Jun 29, 2023

STFS, but it does the same thing with iso and xex.

Then I'll need the path that's causing the problem, I'm not able to reproduce the problem here with my test.

@gibbed
Copy link
Member

gibbed commented Jun 29, 2023

Actually on hindsight, when you say drag&drop onto Xenia, do you mean drag&drop onto the Xenia window, or drag&drop onto xenia.exe?

@Margen67
Copy link
Member Author

Margen67 commented Jun 29, 2023 •
edited
Loading

Actually on hindsight, when you say drag&drop onto Xenia, do you mean drag&drop onto the Xenia window, or drag&drop onto xenia.exe?

I meant drag and drop onto the exe. Dragging and dropping onto the window doesn't have the issue.
I added 你好 to the filename.

@Margen67
Copy link
Member Author

This might be why:

xenia/src/xenia/base/main_win.cc

Line 94 in 00aba94

// Convert all args to narrow, as cxxopts doesn't support wchar.

@Margen67 Margen67 removed the ui label Jun 29, 2023
@AdrianCassar AdrianCassar linked a pull request Jul 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibbed gibbed

Labels
bug vfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BASE] Prevent crashing if special characters are in the launch path AdrianCassar/xenia-canary
2 participants
@gibbed @Margen67