New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove function duplicate #121

Open

JoeSSS opened this issue Jan 1, 2018 · 0 comments

Labels

enhancement good first issue

Milestone

Contributor

JoeSSS commented Jan 1, 2018 •

edited

Loading

waitingForFile function is duplicated in two view controllers:

https://github.com/xing/calabash-launcher/blob/master/Launcher/Classes/ViewControllers/ElementConstructorViewController.swift#L56

https://github.com/xing/calabash-launcher/blob/master/Launcher/Classes/ViewControllers/InspectorViewController.swift#L196

The only difference between two is different UI element animation triggering.

The text was updated successfully, but these errors were encountered:

JoeSSS added feature good first issue labels

JoeSSS added this to the Calabash Launcer 3.0 milestone

JoeSSS added enhancement and removed feature labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment