From 972bac8d87ca04958f3d2c88f3a7bf2ceeb8572f Mon Sep 17 00:00:00 2001 From: Emylee Schonhoeft Date: Sun, 28 Apr 2019 19:06:08 -0500 Subject: [PATCH] Remove int typehint on IDs for FreeCompany & Linkshell as they could be too long for the int type FreeCompany ID's are getting too large to fit in an int. I remove the typehint all together to keep backwards compatibility, so now you can pass an int or string. --- src/XIVAPI/Api/FreeCompany.php | 6 +++--- src/XIVAPI/Api/Linkshell.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/XIVAPI/Api/FreeCompany.php b/src/XIVAPI/Api/FreeCompany.php index 9bc3261..9401ee5 100644 --- a/src/XIVAPI/Api/FreeCompany.php +++ b/src/XIVAPI/Api/FreeCompany.php @@ -18,7 +18,7 @@ public function search(string $name, string $server, int $page = 1) ]); } - public function get(int $id, array $data = []) + public function get($id, array $data = []) { $options = [ RequestOptions::QUERY @@ -31,12 +31,12 @@ public function get(int $id, array $data = []) return Guzzle::get("/freecompany/{$id}", $options); } - public function update(int $id) + public function update($id) { return Guzzle::get("/freecompany/{$id}/update"); } - public function delete(int $id) + public function delete($id) { return Guzzle::get("/freecompany/{$id}/delete"); } diff --git a/src/XIVAPI/Api/Linkshell.php b/src/XIVAPI/Api/Linkshell.php index 94d38e0..4ff400d 100644 --- a/src/XIVAPI/Api/Linkshell.php +++ b/src/XIVAPI/Api/Linkshell.php @@ -18,7 +18,7 @@ public function search(string $name, string $server, int $page = 1) ]); } - public function get(int $id, array $data = []) + public function get($id, array $data = []) { $options = [ RequestOptions::QUERY @@ -31,12 +31,12 @@ public function get(int $id, array $data = []) return Guzzle::get("/linkshell/{$id}", $options); } - public function update(int $id) + public function update($id) { return Guzzle::get("/linkshell/{$id}/update"); } - public function delete(int $id) + public function delete($id) { return Guzzle::get("/linkshell/{$id}/delete"); }