Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xp::stringOf() #324

Closed
thekid opened this issue May 21, 2017 · 1 comment
Closed

Remove xp::stringOf() #324

thekid opened this issue May 21, 2017 · 1 comment
Labels
accepted framework implemented

Comments

@thekid
Copy link
Member

thekid commented May 21, 2017 •
edited
Loading

Scope of Change

This RFC suggests removing xp::stringOf() which is duplicated from util.Objects::stringOf().

Rationale

Cleaning up

Functionality

  1. All libraries will be refactored to use util.Objects instead of xp::stringOf() and released in patch-level releases
  2. The xp::stringOf() method will be deprecated in XP9
  3. The method will be removed from the xp class defined in lang.base.php in the next major release

Security considerations

n/a

Speed impact

Faster

Dependencies

BC break -> Major version

Related documents

RFC #323 - remove xp::typeOf()
@thekid thekid mentioned this issue May 21, 2017
Closed
@thekid thekid mentioned this issue Jun 3, 2017
Merged
@thekid
Copy link
Member Author

thekid commented Jun 3, 2017 •
edited
Loading

⚠️ XP Runners use xp::stringOf() in backtraces for uncaught exceptions and fatals.

@thekid thekid mentioned this issue Jun 3, 2017
Merged
@thekid thekid mentioned this issue Jun 4, 2017
Merged
@thekid thekid closed this as completed Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted framework implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thekid