Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-3 Codec supported or not? README is misleading #209

Open
jamesst20 opened this issue Sep 24, 2024 · 2 comments
Open

AC-3 Codec supported or not? README is misleading #209

jamesst20 opened this issue Sep 24, 2024 · 2 comments

Comments

@jamesst20
Copy link

jamesst20 commented Sep 24, 2024

Hi,

I am not sure if AC-3 codec is supposed to be supported. There are 2 PRs about it:

#99
#103

But then the README says

Screenshot 2024-09-24 at 10 42 55 AM

Versus

Screenshot 2024-09-24 at 10 43 03 AM

----------------------------------------------------

From my testing I am getting the same error as this issue: #115

But looking at the v1.7.3 release:

Screenshot 2024-09-24 at 10 43 39 AM

The support is supposed to be added but then if you take a look at 97 commits to master since this release

Screenshot 2024-09-24 at 10 45 02 AM

You can see support for EAC-3 was added after release but AC-3 before release but then even trying a building the master branch and testing out I am still getting the same error.

Am I missing something?

Here is a video/audio file for testing purposes. Working perfectly in VLC, no audio in mpegts.js

video-h264-audio-ac3.zip

@monyone
Copy link
Collaborator

monyone commented Sep 24, 2024

Currently, ac-3 / ec-3 audio are supported by Safari (MacOS) / Edge (Windows), not supported by Chrome.
mpegts.js using MediaSource Extension, but this API does not support these codecs by Chrome.

@jamesst20
Copy link
Author

/ ec-3 audio are supported by Safari (MacOS) / Edge (Windows), not supported by Chrome.
mpegts.js using MediaSource Extension, but this API does not support these codecs by Chrome.

Thanks @monyone for the quick reply.

I can confirm it does work as expected in Safari on Mac OS. Editing the README could save a lot of confusion :)

Is it something that could be supported in other browser in the future or it's very unlikely? Why Edge and Safari? Because they are native to the OS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants