Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not linkify the URL with super-long TLDs. #601

Closed
tmyt opened this issue Mar 15, 2017 · 6 comments
Closed

Could not linkify the URL with super-long TLDs. #601

tmyt opened this issue Mar 15, 2017 · 6 comments
Labels
duplicate help wanted type/bug Something is misbehaving

Comments

@tmyt
Copy link
Contributor

tmyt commented Mar 15, 2017

Currently Linkifier implimentation could not linkify the URL with super-long TLDs.

Linkifier assume the TLD lenght in 2 - 6 chars in the here,
https://github.com/sourcelair/xterm.js/blob/master/src/Linkifier.ts#L14

But, some new gTLDs have over 6 chars. (ex: .enterprises, .foundation, and so on).
Needs to update tldClause to support these super-long TLD names.

Details

  • xterm.js version: master (ff29fd6)

Steps to reproduce

  1. echo 'https://example.enterprises'
  2. URL does not linked.
@Tyriar Tyriar added the type/bug Something is misbehaving label Mar 15, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2017

PRs welcome, should be an easy fix 👍

@jens1o
Copy link

jens1o commented Jun 22, 2017

@Tyriar Would happy to contribute, for me 256 ought to be enough for anybody? ;)

@Tyriar
Copy link
Member

Tyriar commented Jun 22, 2017

@jens1o the concern with working more on the web link matcher as is, is that it will eventually be replaced by something much smarter that can understand things like when brackets () are within or outside of a URL, see #583

And that one's a bit more work 😛 as it's replacing all the regex logic with a parser that will probably work by finding the start of a link and then move forward until the end is found.

@jens1o
Copy link

jens1o commented Jun 22, 2017

Oh, sorry. I think I won't meet your expectations... Let's hope there will be some nice contributor with some good skills :D

@Tyriar
Copy link
Member

Tyriar commented Jun 22, 2017

No worries 😄

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2018

Merging into #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate help wanted type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

3 participants