-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread error #34
Comments
Ypy isn't thread safe, at least for passing objects between threads. I'm guessing that is causing the issue. Yrs has moved over to using atomics in some areas of the code, so it might be possible to improve Ypy for use in multithreaded applications. Do you have any example code for where the error occurred? |
The issue doesn't happen when passing ypy objects between threads, but when exiting JupyterLab with Ctrl-C. You can reproduce it with this branch. But as this operation uses a thread, maybe it doesn't play well with ypy. All I can say is that it didn't happen before using ypy. |
Could possibly be a PyO3 issue. |
@davidbrochart was this fixed by the time the branch was merged? |
Yes, I think this issue disappeared. Thanks! |
I've noticed that since I've been using y-py in the back-end in Jupyter, I have threading issues while exiting with Ctrl-C:
I know that Yrs uses threads, so it might be related.
The text was updated successfully, but these errors were encountered: