-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer Cursors #112
Comments
Just some updated info on this: multi-cursor support has been removed from Quill in 1.0 and will be reimplement in a future update as explained here: slab/quill#635 |
Peer cursors can be re-implemented into Quill using this project: https://github.com/pedrosanta/quill-sharedb-cursors |
Good news! Hey, they mention you :) |
This type is now part of Yjs. The Quill binding is now in a separate repository https://github.com/y-js/y-quill that also supports shared cursors :) |
Rather than place user data into YJS, I've placed YJS data (YJS User ID) into my user data object as user data is used just as much outside of YJS as inside. In order to keep track of which user is carrying out an action and where specifically, I've needed to make a few changes to both yjs/y-richtext and yjs/y-array.
y-richtext commit
Added the real position of the addition/deletion to the event, as this is what Quill's multi-cursor cares about.
y-array commit
Reimplemented valueID on insert, which has been deleted since the latest release, and added it into deletion.
I've not straight up made a pull request for the following reasons:
The code outside of YJS used to enable this is as follows:
Here's a gif of results after making these changes.
Let me know if this is going down the right road, or if you can suggest a better way of doing this.
The text was updated successfully, but these errors were encountered: