fix: relax RealTheme type for compatibility #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
amje
approved these changes
Sep 7, 2022
ValeraS
reviewed
Sep 7, 2022
src/components/theme/types.ts
Outdated
Comment on lines
1
to
4
| export type RealTheme = string; | ||
| export type ThemeType = 'light' | 'dark'; | ||
|
|
||
| export type Theme = 'system' | RealTheme; |
There was a problem hiding this comment.
Suggested change
| export type RealTheme = string; | |
| export type ThemeType = 'light' | 'dark'; | |
| export type Theme = 'system' | RealTheme; | |
| export type RealTheme = 'light' | 'light-hc' | 'dark' | 'dark-hc'; | |
| export type ThemeType = 'light' | 'dark'; | |
| export type Theme = 'system' | RealTheme | string; |
There was a problem hiding this comment.
That's not enough, problem is in RealTheme type itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current value of
RealThemetype is not compatible with some existing code in services and related libraries. I think it would be better to keep it asstringfor now and move to a more narrow type in the next major release.