Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Default temp directory not deleted on exit #113

Open
jeremiehuchet opened this issue Dec 20, 2017 · 2 comments · May be fixed by #141
Open

Default temp directory not deleted on exit #113

jeremiehuchet opened this issue Dec 20, 2017 · 2 comments · May be fixed by #141
Labels

Comments

@jeremiehuchet
Copy link

jeremiehuchet commented Dec 20, 2017

The default directory where the postgres binary is extracted is not deleted on exit despite of the following line:

File#deleteOnExit() documentation refers to File#delete() and the latter says:

Deletes the file or directory denoted by this abstract pathname. If this pathname denotes a directory, then the directory must be empty in order to be deleted

I expect the temp dir and its content to be deleted on exit. Am I wrong?

@jeremiehuchet
Copy link
Author

Tip How to use your custom version of PostgreSQL acts as a workaround.

@smecsia
Copy link
Member

smecsia commented Jan 3, 2018

Hi @jeremiehuchet . Looks like it is a bug in EmbeddedPostgres class, which is removing data only. Another issue is that by default it uses CachedPostgresArtifactStore which does not remove artifacts intentionally (to optimize the extracted artifacts usage).

I'll think about the proper way of solving this issue. You can now remove the directory manually as a workaround.

@smecsia smecsia added the bug label Jan 3, 2018
@footaku footaku linked a pull request Aug 24, 2018 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants