[Tests] clean up some test cases

jsx-eslint · Dec 28, 2020 · a137a04 · a137a04
1 parent 9e4bbd0
commit a137a04
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 16 deletions.
diff --git a/tests/lib/rules/jsx-uses-react.js b/tests/lib/rules/jsx-uses-react.js
@@ -62,11 +62,27 @@ ruleTester.run('no-unused-vars', rule, {
   }, parsers.TS([{
     code: '/*eslint jsx-uses-react:1*/ var Frag; <></>;',
     errors: [{message: '\'Frag\' is defined but never used.'}],
+    parser: parsers.TYPESCRIPT_ESLINT,
+    settings: {react: {fragment: 'Fragment'}}
+  }, {
+    code: '/*eslint jsx-uses-react:1*/ var Frag; <></>;',
+    errors: [{message: '\'Frag\' is defined but never used.'}],
+    parser: parsers['@TYPESCRIPT_ESLINT'],
     settings: {react: {fragment: 'Fragment'}}
   }, {
     code: '/*eslint jsx-uses-react:1*/ var React; <></>;',
     parser: parsers.BABEL_ESLINT,
     errors: [{message: '\'React\' is defined but never used.'}],
     settings
+  }, {
+    code: '/*eslint jsx-uses-react:1*/ var React; <></>;',
+    parser: parsers.TYPESCRIPT_ESLINT,
+    errors: [{message: '\'React\' is defined but never used.'}],
+    settings
+  }, {
+    code: '/*eslint jsx-uses-react:1*/ var React; <></>;',
+    parser: parsers['@TYPESCRIPT_ESLINT'],
+    errors: [{message: '\'React\' is defined but never used.'}],
+    settings
   }]))
 });
diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2596,7 +2596,8 @@ ruleTester.run('prop-types', rule, {
       },
       // shouldn't trigger this rule for 'render' since functions stating with a lowercase
       // letter are not considered components
-      `
+      {
+        code: `
         const MyComponent = (props) => {
           const render = () => {
             return <test>{props.hello}</test>;
@@ -2606,7 +2607,9 @@ ruleTester.run('prop-types', rule, {
         MyComponent.propTypes = {
           hello: PropTypes.string.isRequired,
         };
-      `,
+        `,
+        parser: parsers['@TYPESCRIPT_ESLINT']
+      },
       {
         code: `
           interface Props {
@@ -3108,19 +3111,6 @@ ruleTester.run('prop-types', rule, {
         code: `
           import React from 'react'
 
-          class Factory {
-            getRenderFunction() {
-              return function renderFunction({ name }) {
-                return <div>Hello {name}</div>
-              }
-            }
-          }
-        `
-      },
-      {
-        code: `
-          import React from 'react'
-
           type ComponentProps = {
             name: string
           }
@@ -3135,7 +3125,20 @@ ruleTester.run('prop-types', rule, {
         `,
         parser: parsers['@TYPESCRIPT_ESLINT']
       }
-    ])
+    ]),
+    {
+      code: `
+        import React from 'react'
+
+        class Factory {
+          getRenderFunction() {
+            return function renderFunction({ name }) {
+              return <div>Hello {name}</div>
+            }
+          }
+        }
+      `
+    }
   ),
 
   invalid: [].concat(