Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report data leakage that causes unfair few-shot setting #56

Open
Ze-Yang opened this issue Jan 6, 2021 · 1 comment
Open

Report data leakage that causes unfair few-shot setting #56

Ze-Yang opened this issue Jan 6, 2021 · 1 comment

Comments

@Ze-Yang
Copy link
Contributor

Ze-Yang commented Jan 6, 2021

I think there exists a data leakage problem in your code, which severely hurts the fair comparison with other methods.

Take coco 10shot for example, you will first construct a meta-data set encomprising 30 (3x shots) (prn_image, prn_mask) pairs for each class. The image indexes of these sampled images are saved in a file named annotations/instances_shot2014.json.

After that, roidb needs to be contructed to provide query samples for finetuning purpose. According to the definition of few-shot setting, you can only access to the N-shot (N instances per class) data no matter whether you perform finetuning or not. Therefore, the roidb dataset should contain the same instances as in meta-data set, otherwise it will exceed the designated number of shots. However, as I find in your code, you does not save the anno_index of the selected instances in meta-data set. Instead, you again randomly sample the shot instances from the images list indicated in annotations/instances_shot2014.json. In this case, I am concern about how you guarantee that the newly sampled instances are exactly the same as the ones in meta-data set.

Hope that you can check about this issue and clarify my concern. Thanks a lot.

@chengyu0910
Copy link

chengyu0910 commented Dec 21, 2021

yes, I found this problem too, it beyonds k-shot instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants