Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fs.watchFile does not work with a virtual FS #1268

Closed
1 task done
dalinarkholin opened this issue Apr 29, 2020 · 1 comment · Fixed by #1691
Closed
1 task done

[Bug] fs.watchFile does not work with a virtual FS #1268

dalinarkholin opened this issue Apr 29, 2020 · 1 comment · Fixed by #1691
Labels
bug Something isn't working upholded Real issues without formal reproduction

Comments

@dalinarkholin
Copy link

  • I'd be willing to implement a fix (maybe if I can find the time )

Describe the bug

fs.watchFile does not trigger change events when the file path is a virtual one.

this implementation is used within Chokidar when polling(usePolling) is enabled(example: via webpack)

To Reproduce

No repro at the moment.

Per @arcanis

"ideally just a simple Node script using fs.watchFile, so no webpack or anything"

"I suspect the fix will be to override watchFile and/or watch in the VirtualFS
https://github.com/yarnpkg/berry/blob/master/packages/yarnpkg-fslib/sources/VirtualFS.ts"

Additional context

#1209 is related.

@dalinarkholin dalinarkholin added the bug Something isn't working label Apr 29, 2020
@yarnbot

This comment has been minimized.

@yarnbot yarnbot added the stale Issues that didn't get attention label Jun 9, 2020
@paul-soporan paul-soporan added upholded Real issues without formal reproduction and removed stale Issues that didn't get attention labels Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upholded Real issues without formal reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants