Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Possible memory leak in either workspaces foreach or version prerelease #2584

Closed
1 task done
kasperisager opened this issue Mar 9, 2021 · 6 comments
Closed
1 task done
Labels
bug Something isn't working stale Issues that didn't get attention

Comments

@kasperisager
Copy link

kasperisager commented Mar 9, 2021

  • I'd be willing to implement a fix

Describe the bug

I seem to be experiencing a pretty consistent ENOMEM error when attempting to bump packages for prerelease in a GitHub Actions workflow:

yarn workspaces foreach --no-private --topological version --deferred prerelease

This is the latest workflow run that failed: https://github.com/Siteimprove/alfa/runs/2064158138

To reproduce

I really wish I had something more to share, but I've been unable to reproduce this locally. It seems like such a simple command that it'd be the last thing I'd expect to fail with an OOM error. I'll keep digging and share anything additional I might discover.

Environment

  • OS: Ubuntu 18.04.5
  • Node version: 14.16.0
  • Yarn version: 2.4.0-git.20210308.hash-53e33b45
@kasperisager kasperisager added the bug Something isn't working label Mar 9, 2021
@kasperisager
Copy link
Author

Fails under Ubuntu 20.04.2 and Node.js 15.11.0 as well: https://github.com/Siteimprove/alfa/runs/2065547455

@kasperisager
Copy link
Author

Works under macOS 10.15 and Node.js 15.11.0: https://github.com/Siteimprove/alfa/runs/2066026535

@kasperisager
Copy link
Author

I hit a wall on the later steps of what I was trying to achieve with this and so won't spend more time debugging it: #2585

@merceyz
Copy link
Member

merceyz commented Mar 27, 2021

Tried to reproduce on both Windows and Ubuntu 20.4 using Node 15.11.0, 15.12.0, and 14.16.0, all of them pass

/usr/bin/time -v yarn workspaces foreach --no-private --topological version --deferred prerelease
➤ YN0000: Done in 16s 831ms
        Command being timed: "yarn workspaces foreach --no-private --topological version --deferred prerelease"
        Maximum resident set size (kbytes): 423500

@yarnbot
Copy link
Collaborator

yarnbot commented Apr 26, 2021

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟

@yarnbot yarnbot added the stale Issues that didn't get attention label Apr 26, 2021
@LaurensUP
Copy link

I'm having the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Issues that didn't get attention
Projects
None yet
Development

No branches or pull requests

4 participants