Fixes bin overwrites #7755
Merged
Fixes bin overwrites #7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arcanis
added a commit
that referenced
this pull request
Dec 11, 2019
* Fixes potential file overwrite at install time * Fixes the regexp * Adds warnings * Fixes overzealous removals * Fixes test * Adds tests
|
Hey @arcanis, we've bumped into a new warning about For example: {
"bin": {
"build.cli": "./cli.js"
}
} |
|
This breaks my build as well. Some of my bins have dots in their names, including a few that I have no control over. |
|
Hey @arcanis, this breaks some packages from building because bin key names contain colons. Why so restrictive on the bin key name validation? |
|
The name check is slightly too restrictive, but I don't have bandwidth to fix that atm. Please open a PR and link it here. |
|
@arcanis done |
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Fixes potential file overwrite at install time * Fixes the regexp * Adds warnings * Fixes overzealous removals * Fixes test * Adds tests
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Fixes potential file overwrite at install time * Fixes the regexp * Adds warnings * Fixes overzealous removals * Fixes test * Adds tests
rivy
added a commit
to rivy/scoop-bucket
that referenced
this pull request
Oct 31, 2020
- using 1.19.2 as primary version; 1.22.5 has "invalid 'bin'" issues - ref: yarnpkg/yarn#7755 - ref: yarnpkg/yarn#7811 - but... *still* a problem even after PR#7811
rivy
added a commit
to rivy/scoop-bucket
that referenced
this pull request
Nov 8, 2020
- using 1.19.2 as primary version; 1.22.5 has "invalid 'bin'" issues - ref: yarnpkg/yarn#7755 - ref: yarnpkg/yarn#7811 - but... *still* a problem even after PR#7811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some circumstances Yarn would allow overwriting files on the filesystem with symlinks at install-time. Despite postinstall scripts having the ability to do that anyway this behavior isn't intended as Yarn installs are reputed to control side effects (the cache and temporary folders being the only exception). Bins shouldn't be able to escape the package because of Yarn.
Test plan
Adding tests