feat(diagnostics): render bloom filter better #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunga
force-pushed
the
better-bloom-filter
branch
2 times, most recently
from
c808dad
to
23e673b
Compare
artemmufazalov
requested changes
Aug 16, 2024
| label: i18n('label.bloom-filter'), | ||
| value: EnableFilterByKey ? i18n('enabled') : i18n('disabled'), | ||
| }); | ||
| if (EnableFilterByKey != undefined) { |
There was a problem hiding this comment.
It's better to use helper valueIsDefined or at least compare strictly !==. In this case it seems that there is no difference, but it generally good practice to avoid possible errors further
kunga
force-pushed
the
better-bloom-filter
branch
from
23e673b
to
9fba403
Compare
artemmufazalov
approved these changes
Aug 16, 2024
artemmufazalov
force-pushed
the
better-bloom-filter
branch
from
955f7b4
to
da528ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1080
Also removed bloom filter enable from default create table