fix: default value fixes #1166
Merged
fix: default value fixes #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
Aug 15, 2024
| @@ -81,7 +81,7 @@ function prepareRowTableSchema(data: TTableDescription = {}): SchemaData[] { | |||
| type: Type, | |||
| notNull: NotNull, | |||
| autoIncrement: Boolean(DefaultFromSequence), | |||
| defaultValue: DefaultFromLiteral?.value?.text_value, | |||
| defaultValue: Object.values(DefaultFromLiteral?.value || {})[0] || '-', | |||
There was a problem hiding this comment.
Why did you decide to use such a logic? It seems less obvious than prev version.
Why not just DefaultFromLiteral?.value?.text_value || '-' ?
There was a problem hiding this comment.
because field with value has different naming depends on it's type. i.e. bool_value for bool, text_value for string...
There was a problem hiding this comment.
Now i see... but lets also fix it in types DefaultFromLiteral.
| @@ -102,7 +102,7 @@ const defaultValueColumn: SchemaColumn = { | |||
| return i18n('column-title.defaultValue'); | |||
| }, | |||
| width: 100, | |||
| render: ({row}) => row.defaultValue, | |||
| render: ({row}) => String(row.defaultValue), | |||
There was a problem hiding this comment.
No need in explicit transformation, typescript should catch that defaultValue is always string.
There was a problem hiding this comment.
it doesn't work for bool such way
Raubzeug
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 78.90 MB | Main: 78.90 MB
Diff: 0.03 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information