Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DecommissionButton): add checkbox to dialog #1294

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(DecommissionButton): add checkbox to dialog #1294

merged 1 commit into from
Sep 16, 2024

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Sep 13, 2024 •
edited by github-actions bot
Loading

Closes #1207

CI Results

Test Status: ❌ FAILED

📊 Full Report

Total Passed Failed Flaky Skipped
124 117 1 6 0

Bundle Size: 🔺

Current: 78.85 MB | Main: 78.81 MB
Diff: +0.04 MB (0.05%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov merged commit 6d65839 into main Sep 16, 2024
5 of 6 checks passed
@artemmufazalov artemmufazalov deleted the 1207-decommission-dialog-checkbox branch September 16, 2024 06:44
@ydb-platform-bot ydb-platform-bot mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raubzeug Raubzeug Raubzeug approved these changes

@astandrik astandrik Awaiting requested review from astandrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checkbox to PDisk decommission dialog
2 participants
@artemmufazalov @Raubzeug