feat: add/drop table index template #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
Oct 14, 2024
| @@ -36,6 +36,7 @@ | |||
| "actions.dropTopic": "Drop topic...", | |||
| "actions.dropView": "Drop view...", | |||
| "actions.alterTable": "Alter table...", | |||
| "actions.addTableIndex": "Add index...", | |||
There was a problem hiding this comment.
Don't we want to add action "Drop index..." directly to index entity?
| @@ -248,3 +248,11 @@ export const dropAsyncReplicationTemplate = () => { | |||
| export const alterAsyncReplicationTemplate = () => { | |||
| return `ALTER ASYNC REPLICATION \`$path\` SET (STATE=\`$state\`, FAILOVER_MODE=\`$failoverMode\`);`; | |||
| }; | |||
|
|
|||
| export const addTableIndex = () => { | |||
There was a problem hiding this comment.
We may use function addTableIndex('$path') from src/containers/Tenant/utils/schemaQueryTemplates.ts . In most cases templates are identical.
What do you think if we create general template creators and use them if possible? This will prevent double-fixing templates.
There was a problem hiding this comment.
on a second thougth this can be done right here
Raubzeug
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1454
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔽
Current: 78.97 MB | Main: 78.98 MB
Diff: 0.01 MB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information