Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace EntityStatus with StatusIcon where possible #1518

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Oct 23, 2024

In some places we had EntityStatus without name prop. Because now it has minimum width, without name it looks weird. Replaced it with StatusIcon where it's possible

Before:
Screenshot 2024-10-23 at 12 58 00

After:
Screenshot 2024-10-23 at 12 58 12

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
134 134 0 0 0

Bundle Size: ✅

Current: 79.04 MB | Main: 79.04 MB
Diff: +0.12 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 017c82a Oct 23, 2024
5 checks passed
@artemmufazalov artemmufazalov deleted the replace-entity-status branch October 23, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants