feat: update breadcrumbs #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jun 21, 2023
Comment on lines
+29
to
+34
| { | ||
| nodeId: NodeId, | ||
| type: Type, | ||
| state: State, | ||
| tenantName, | ||
| }, |
There was a problem hiding this comment.
Pass these params as query for immediate breadcrumbs render on Tablet page
artemmufazalov
commented
Jun 21, 2023
| @@ -28,6 +28,8 @@ import {clusterTabsIds} from '../Cluster/utils'; | |||
| const b = cn('app'); | |||
|
|
|||
| export function Content(props) { | |||
| const location = useLocation(); | |||
There was a problem hiding this comment.
Location was used but was not declared
artemmufazalov
commented
Jun 21, 2023
| const {singleClusterMode, header}: {singleClusterMode: boolean; header: HeaderItemType[]} = | ||
| useTypedSelector((state) => state); | ||
| interface HeaderProps { | ||
| mainPage?: RawBreadcrumbItem; |
There was a problem hiding this comment.
mainPage - additional breadcrumbs item for the extended versions (all clusters page)
Raubzeug
approved these changes
Jun 23, 2023
artemmufazalov
force-pushed
the
breadcrumbs
branch
from
6bfb794
to
7d5f1a7
Compare
Raubzeug
approved these changes
Jun 23, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster page
Breadcrumbs: ClusterName
Tenant page
Breadcrumbs: ClusterName / TenantName
Node page
Breadcrumbs (storage node): ClusterName / NodeID
Breadcrumbs (compute node): ClusterName / TenantName / NodeID
Tablets page
Breadcrumbs (cluster system tablets): ClusterName / Tablets
Breadcrumbs (tenants tablets): ClusterName / TenantName / Tablets
Tablet page
Breadcrumbs (cluster system tablets): ClusterName / Tablets / TabletID
Breadcrumbs (tenants tablets): ClusterName / TenantName / Tablets / TabletID
